Avoid merging category-companies@cn into geolocation-cn#19
Open
tr4v3ler wants to merge 1 commit into
Open
Conversation
Keep company-wide @cn buckets like google@cn out of the generic mainland direct list so generated geolocation-cn does not classify blocked Google service domains as direct-connect targets. Made-with: Cursor
|
Yes, I blocked SagerNet/sing-geosite/rule-set/geosite-cn.srs in server side, then google chrome download is also blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
category-companies@cnfrom the extrageolocation-cnmerge inmergeTags()category-*@cnmerges intactWhy
v2fly/domain-list-communityrawgeolocation-cndoes not includegoogle, butcategory-companiesincludesgoogle, andgoogle@cncontains domains such asssl.gstatic.com,www.gstatic.com, andfonts.googleapis.com.When
category-companies@cnis merged intogeolocation-cn, the generated rule-set becomes too broad for common mainland direct-routing usage and may classify blocked Google service domains as direct-connect targets.This change keeps the existing merge behavior for the other category-based
@cnbuckets, while preventing thecategory-companies@cnexpansion from pulling mixed-accessibility company domains intogeolocation-cn.Test plan
go test ./...Made with Cursor