Skip to content

Avoid merging category-companies@cn into geolocation-cn#19

Open
tr4v3ler wants to merge 1 commit into
SagerNet:mainfrom
tr4v3ler:fix-geolocation-cn-company-merge
Open

Avoid merging category-companies@cn into geolocation-cn#19
tr4v3ler wants to merge 1 commit into
SagerNet:mainfrom
tr4v3ler:fix-geolocation-cn-company-merge

Conversation

@tr4v3ler

Copy link
Copy Markdown

Summary

  • exclude category-companies@cn from the extra geolocation-cn merge in mergeTags()
  • add a focused test covering the exclusion while keeping other category-*@cn merges intact

Why

v2fly/domain-list-community raw geolocation-cn does not include google, but category-companies includes google, and google@cn contains domains such as ssl.gstatic.com, www.gstatic.com, and fonts.googleapis.com.

When category-companies@cn is merged into geolocation-cn, the generated rule-set becomes too broad for common mainland direct-routing usage and may classify blocked Google service domains as direct-connect targets.

This change keeps the existing merge behavior for the other category-based @cn buckets, while preventing the category-companies@cn expansion from pulling mixed-accessibility company domains into geolocation-cn.

Test plan

  • run go test ./...

Made with Cursor

Keep company-wide @cn buckets like google@cn out of the generic mainland direct list so generated geolocation-cn does not classify blocked Google service domains as direct-connect targets.

Made-with: Cursor
@bash99

bash99 commented Apr 15, 2026

Copy link
Copy Markdown

Yes, I blocked SagerNet/sing-geosite/rule-set/geosite-cn.srs in server side, then google chrome download is also blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants