Fix bad import of pandas#1395
Merged
Merged
Conversation
thomasyu888
reviewed
Jun 5, 2026
thomasyu888
approved these changes
Jun 5, 2026
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM! I'll defer to someone on the team for final review, and lets make sure this makes it into dev branch at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An import of pandas was added at the top lvel of a module. This doesn't break any tests, but it causes an import error when the check-build workflow does
synapse --versionwith the test-pypi package.This is fixed by removing the module-level import and moving it to the function.