[SYNPY-1829] re-enable test#1393
Open
linglp wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously skipped integration tests for external STS storage locations now that the underlying platform issues have been addressed (per SYNPY-1829).
Changes:
- Removed the
@pytest.mark.skip(...)decorators that were disabling STS-related external storage integration tests. - Restored execution of
test_sts_external_storage_locationandtest_boto_upload_aclas part of the normal integration test run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrewelamb
reviewed
Jun 4, 2026
| # @skip("Skip integration tests for soon to be removed code") | ||
| @pytest.mark.skip( | ||
| reason="Skip integration test because it gets stuck, causing CI timeout on Github actions. " | ||
| ) |
Contributor
There was a problem hiding this comment.
Is there a plan to fix this test?
Contributor
Author
There was a problem hiding this comment.
I will post this issue to the team after all the tests pass. But I am thinking we probably won't fix it since this is one of the legacy functions that will be replaced soon anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable test after platform fixes. See ticket: https://sagebionetworks.jira.com/browse/SYNPY-1829