Make multi-selection reliable and add bulk canvas actions - #10
Merged
Conversation
Fuzzdkk
marked this pull request as ready for review
July 24, 2026 10:58
Member
|
Jesus man you have been cooking some amazing stuff. Will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I was running into cases where quickly Shift-clicking several assets would replace the current selection or miss a click.
There were two causes:
The selection state is now synchronized before React Flow handles the pointer event, and nodes allow a small amount of click movement.
What changed
Demo
Shift selection stability
Rapidly adding and removing assets while holding Shift.
shift-selection-stability.mov
Bulk editing toolbar
Using the shared toolbar with a selection containing assets and routes.
bulk-editing-toolbar.mp4
Copying connected assets
Copying and pasting two selected assets while preserving the route and detail box between them.
copy-paste-with-details-node.mov
Testing
I tested:
Note
I started working on this before the Ctrl-selection change in #6 landed. After updating the branch, I kept that implementation in place and focused this work on Shift-click reliability and the actions available once multiple items are selected.
Control-click is also the native context-menu gesture on macOS, so it does not behave reliably as a selection modifier there. I have left that behavior unchanged. Would you prefer Shift to remain the Mac selection modifier, or should macOS use Command-click while Windows and Linux retain Ctrl?
I needed this for working with larger canvases, but I’m open to splitting parts of it out or handling the interaction differently if that fits the project better.