ci: design-tokens 동기화 자동 PR 워크플로우 등록 #24#25
Conversation
- SWYP-Find/design-tokens 의 Mode 1.tokens.json 을 가져와 TokenGenerator를 돌리고 변경이 있으면 develop 대상 PR 생성 - workflow_dispatch · 매일 10:00 KST 스케줄 · design-tokens 측 repository_dispatch 트리거 지원 - 동작에 secrets.DESIGN_TOKENS_TOKEN (private repo 읽기 권한 PAT) 필요
- 일일 스케줄 제거하고 workflow_dispatch 와 repository_dispatch(design-tokens-updated) 만 유지 - 디자인 토큰 레포의 push 알림이 도착할 때 실 변경분만 PR로 올라가도록 정리
|
fast-forward로 develop에 직접 push되어 자동 종료 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26ee934221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "[sync] downloaded $(wc -c < "${LOCAL_JSON_PATH}") bytes" | ||
|
|
||
| - name: Run TokenGenerator | ||
| run: swift Tools/TokenGenerator.swift |
There was a problem hiding this comment.
Point workflow to a real TokenGenerator script
This step runs swift Tools/TokenGenerator.swift, but this commit does not add that file (and the repo tree at this revision has no Tools/TokenGenerator.swift), so every workflow run will fail before change detection or PR creation. Unless the script path is corrected to an existing file in the repository, the automation introduced here cannot succeed.
Useful? React with 👍 / 👎.
| if git diff --quiet -- \ | ||
| "${LOCAL_JSON_PATH}" \ |
There was a problem hiding this comment.
Include untracked files in change detection
Using git diff --quiet here only checks tracked modifications and ignores newly created files, so the workflow can report changed=false even when the generator creates new token outputs. In this revision, several target paths are not tracked yet, which means the first sync can silently skip PR creation despite producing files.
Useful? React with 👍 / 👎.
개요
workflow_dispatch/repository_dispatch트리거가 모든 브랜치에서 동작하도록 default branch(develop)에 워크플로우 파일을 등록합니다.변경
.github/workflows/sync-design-tokens.yml신설workflow_dispatch,repository_dispatch(design-tokens-updated)SWYP-Find/design-tokens의Mode 1.tokens.json다운로드 →swift Tools/TokenGenerator.swift실행 → 변경 있으면 develop 대상 PR 자동 생성머지 후 필요한 secrets
Picke-iOS: `DESIGN_TOKENS_TOKEN` (design-tokens 읽기 권한 PAT)design-tokens: `IOS_REPO_DISPATCH_TOKEN` (Picke-iOS Actions 트리거 권한 PAT)테스트 플랜
Sync Design Tokens수동 실행