Skip to content

IFDM-140: updating text#92

Open
jenbreese wants to merge 1 commit into1.xfrom
IFDM-140
Open

IFDM-140: updating text#92
jenbreese wants to merge 1 commit into1.xfrom
IFDM-140

Conversation

@jenbreese
Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

Summary

  • Rename "Compounding period" to "Compounding frequency"
  • Change the capitalization to be consistent with the rest of our calculators. Right now, out calulators have the first word capitalized then the remaining words lowercase. For example: Annual interest rate
  • Can we change the "Time period" input box to "Number of compounding periods". Right now, we have the time period in years, so we would need to adjust the calculation as well as the wording. This will make the calculator more in-line with our interest calculator.
  • Can we also remove the line that says: "X compounding periods" under the time period input box.
    - Ticket

An example of the math: Initial amount: $1,000

Annual interest rate: 5%

Number of compounding periods: 12

Compounding frequency: Monthly

Final amount: $1,051.16

Review By (Date)

  • 4/17

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to the calculator
  3. Verify all the text changes are done.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants