tests: renamed test_failover to test_connectivity#8713
Open
danlavu wants to merge 2 commits into
Open
Conversation
danlavu
commented
May 18, 2026
danlavu
commented
- added dns resolution failure test
- renamed failover tests to connectivity test naming
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames several existing failover tests to a more descriptive "test_connectivity__" naming convention and introduces a new test case to verify SSSD's behavior when DNS traffic is blocked. A review comment correctly identified a contradiction in the new test where the name and documentation suggest SSSD should fail to start, while the code actually asserts that it starts successfully; a correction for this and a typo was suggested.
danlavu
force-pushed
the
tests-failover-dns
branch
from
e6f33b3 to
deec97a
Compare
added 2 commits
May 21, 2026 18:48
danlavu
force-pushed
the
tests-failover-dns
branch
2 times, most recently
from
60fb4bd to
b499746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.