Tests: LDAP+KRB5 krb_misc tests#8655
Conversation
madhuriupadhye
requested review from
aplopez,
danlavu and
spoore1
and removed request for
danlavu
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds three new system tests to the SSSD test suite, covering authentication scenarios with unresolvable kpasswd, handling of setuid(-1) helper processes, and password changes via SSH. The review feedback highlights the need to explicitly set the SSSD debug level to ensure logs are captured correctly for assertions, suggests reordering log checks to ensure they run even if authentication fails, and recommends adding a sleep delay to avoid race conditions when reading log files.
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
While I think some of the gemini review comments are worth at least taking note of, this backport to sssd-2-13 looks good to me.
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
madhuriupadhye
force-pushed
the
bp_ldap_krb
branch
2 times, most recently
from
a2bbc56 to
478c06d
Compare
Ported following test case: - kpasswd: BZ 847039: login works when krb5_kpasswd is unresolvable (kpasswd not needed for auth). - high UID: BZ 798655: auth and logs stay clean with a setuid(-2) helper process running. - password change: GH 677: SSH passwd with chpass_provider=krb5 logs initial auth in krb5_child.log. Backporting of SSSD#8612 Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com> Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com>
|
The pull request was accepted by @madhuriupadhye with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
6 participants
Ported following test case:
Backporting of #8612