99% SystemWipeHolder and a couple of small things#1932
Merged
Conversation
Report for RMGK01 (fe41c87 - 57b1216)📈 Matched code: 55.67% (+0.03%, +1616 bytes) ✅ 16 new matches
📈 1 improvement in an unmatched item
|
ThatNintendoNerd
requested changes
Jun 16, 2026
Comment on lines
+6
to
+7
| #include "JSystem/J2DGraph/J2DPicture.hpp" | ||
| #include "JSystem/JUtility/JUTVideo.hpp" |
Collaborator
There was a problem hiding this comment.
Wrap library include directives with angle brackets instead of quotation marks.
Comment on lines
+13
to
+15
| addWipeLayout(new WipeFade("フェードワイプ", Color8(0x00, 0x00, 0x00, 0xFF))); | ||
| addWipeLayout(new WipeRing(false, "円ワイプ")); | ||
| addWipeLayout(new WipeFade("白フェードワイプ", Color8(0xFF, 0xFF, 0xFF, 0xFF))); |
Collaborator
There was a problem hiding this comment.
Prefer decimal notation for color values instead of hexadecimal.
| } | ||
|
|
||
| void SystemWipeHolder::drawGameScreenCapture() const { | ||
| if (_1C) { |
Collaborator
There was a problem hiding this comment.
Return early if _1C is false.
| f32 width = MR::getScreenWidth(); | ||
| // inlined MR::getscreenHeight | ||
| f32 height = (s32)JUTVideo::getManager()->getEfbHeight(); | ||
| ; |
Collaborator
There was a problem hiding this comment.
Unnecessary line with stray semicolon.
Contributor
Author
|
all requested changes have been adressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.