fix: propagate suspend result in Redis request invoker#52
Open
fix: propagate suspend result in Redis request invoker#52
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes coroutine suspension propagation for Redis request handler invocation by returning the result of the underlying MethodHandle call in the suspend-path of the hidden-class invoker template, ensuring COROUTINE_SUSPENDED is not dropped during handler dispatch.
Changes:
- Propagate the return value of
HANDLE.invoke(context, $completion)for suspend request handlers so coroutine suspension/resumption works correctly. - Leave non-suspend handler invocation behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
COROUTINE_SUSPENDEDis not dropped and in-flight continuations/responses are not lost.Description
HANDLE.invoke(context, $completion)in theIS_SUSPENDbranch ofRedisRequestHandlerInvokerTemplate.invoke(...)so the suspend call's result (e.g.,COROUTINE_SUSPENDED) is propagated, while leaving the non-suspend branch unchanged.Testing
./gradlew :surf-redis-core:test, but the build could not run in this environment because the configured Gradle plugin requires Java 25 while the runner JVM is Java 21, so no automated test results were produced.Codex Task