scst_vdisk: enable bind_alua_state for fileio devices#366
Merged
lnocturno merged 1 commit intoMay 15, 2026
Conversation
Wire the on_alua_state_change_{start,finish} callbacks into
vdisk_file_devtype and expose bind_alua_state as a sysfs attribute
and create-time parameter for fileio. The callback bodies were
already backing-agnostic; rename them from blockio_* to vdev_* to
match.
Default bind_alua_state=0 for fileio (vs. 1 for blockio) to preserve
existing behavior on upgrade. Adjust the sysfs show function to
compare against the per-backing default so scstadmin persists
explicit settings correctly.
Contributor
|
Hi Brian, Thank you for the patch! Gleb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the on_alua_state_change_{start,finish} callbacks into vdisk_file_devtype and expose bind_alua_state as a sysfs attribute and create-time parameter for fileio. The callback bodies were already backing-agnostic; rename them from blockio_* to vdev_* to match.
Default bind_alua_state=0 for fileio (vs. 1 for blockio) to preserve existing behavior on upgrade. Adjust the sysfs show function to compare against the per-backing default so scstadmin persists explicit settings correctly.