Conversation
Contributor
Angelyr
commented
Nov 24, 2024
Angelyr
commented
- Removed usages of comm_world
- Provide a runtime API to return the current version number of the software.
- Have no hardwired print or IO statements that cannot be turned off.
- Added doxygen documentation
- Added smoke test
- version comparison preprocessor macros.
Angelyr
requested review from
cwsmith and
jacobmerson
and removed request for
cwsmith
cwsmith
reviewed
Nov 25, 2024
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
LGTM. Thank you. A few comments are below.
jacobmerson
reviewed
Nov 28, 2024
Contributor
|
Thanks Angel! I provided a few comments. |
jacobmerson
approved these changes
Dec 2, 2024
Contributor
jacobmerson
left a comment
jacobmerson
left a comment
There was a problem hiding this comment.
Updates look good. Thanks!
Contributor
|
@cwsmith do you want to review this before merge? |
cwsmith
approved these changes
Dec 4, 2024
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. Thank you. I just had one question below.
jacobmerson
approved these changes
Dec 4, 2024
Contributor
|
Looks good. Thanks Angel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.