Skip to content

SBND Timing Reconstruction Refactor#915

Open
VCLanNguyen wants to merge 64 commits into
developfrom
feature/frame_shift_refactor_v10_14_02
Open

SBND Timing Reconstruction Refactor#915
VCLanNguyen wants to merge 64 commits into
developfrom
feature/frame_shift_refactor_v10_14_02

Conversation

@VCLanNguyen
Copy link
Copy Markdown
Contributor

@VCLanNguyen VCLanNguyen commented Feb 14, 2026 •
edited
Loading

Description

  • Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
  • After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
  • Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
  • The timing correction applied at CAFMakeer is undone. - The timing correction applied at CAFMakeer is undone. This should ressolve this issue: Converge timing correction in CAFMaker for SBND and ICARUS sbncode#567
  • Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=46654

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
#847

This PR needs to be merged together with this group of PRs:

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

VCLanNguyen and others added 30 commits November 11, 2025 16:24
@VCLanNguyen
refactor frameshift module to run at decode stage
f527fb8
@VCLanNguyen
add timing channel
7e7c3c4
@VCLanNguyen
add initialisation as max uint64_t
8d8d8a1
@henrylay97
Use namespace and enumeration
daa63dc
@henrylay97
Begin functionalisation
6739521
@henrylay97
Make constexpr for regularly used cast
f7dead4
@henrylay97
Make function for formatting timestamp
34e6ffe
@henrylay97
Functionalise frame TDC/PTB definitions
500d130
@henrylay97
Reduce duplication in final logic
a21b73f
@henrylay97
Consistent indentation
4697328
@henrylay97
Clean up fcl parameters and document
8102b2e
@VCLanNguyen
Merge pull request #883 from SBNSoftware/feature/frameshift_refactor_…
ce18cbd 
…v10_11_01_hlay_functions

Functionalise
@VCLanNguyen
adjust fcl parameters
6a24518
@henrylay97
Move constexpr upstream
2d93ca4
@henrylay97
Use FrameShiftInfo object in CRT data reconstruction
857c9ed
@henrylay97
Add catch for NoShift and allow cutting on ETrig frame
3ca8e1b
@lynnt20
add frameshift functionality instead of direclty referencing spec tdc…
d849488 
…/ptb
@lynnt20
use the pmt calibdb to create the channel mapping
370cd81
@lynnt20
vectors are initialized with size,value using parantheses, not braces...
6dcca71
@lynnt20
add sbnd services to include pmt calibdb + trigger emulation
761ef7c
@VCLanNguyen
Merge pull request #912 from SBNSoftware/feature/frameshift_refactor_…
c66aaa3 
…v10_11_01_pmt_crt

Add PMT/CRT decoder
@VCLanNguyen
update subsystem decoder fcl to include frameshift
a32bc3d
@asanchezcastillo
Update LightPropagation module for new timing frmae
57b8b56
@lynnt20
clarify fcl param to only count the number of PMT channels per CAEN, …
825c07d 
…not all channels per CAEN
@VCLanNguyen
update to include Run 2 HLT
c621ba3
@VCLanNguyen
Merge branch 'feature/frameshift_refactor_v10_11_01' of https://githu…
f2bc6f9 
…b.com/SBNSoftware/sbndcode into feature/frameshift_refactor_v10_11_01
@VCLanNguyen
Merge branch 'feature/frameshift_refactor_v10_11_01' of https://githu…
9e19ef9 
…b.com/SBNSoftware/sbndcode into feature/frame_shift_refactor_v10_14_02
@VCLanNguyen
grab the nanosecond part of timestemp
0ab99f6
@aliciavr
Merge branch 'feature/aliciavr_XARAPUCA_offline_decoder_v4.0-extended…
a27480d 
…_fragments' into feature/aliciavr-XARAPUCA-offline-decoder-v5.0-frameshift-refactor
@aliciavr
feat (frameshift): Add frameshift module to the configuration and acc…
bb1ac48 
…ess its products. Additionally, set a frameshift mode boolean t be activated when selecting the frameshift timestamp (this one to be integrated in the workflow)
@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis
Copy link
Copy Markdown
Contributor

aantonakis commented May 12, 2026

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188,LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis
Copy link
Copy Markdown
Contributor

aantonakis commented May 12, 2026

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188,LArSoft/lar*@LARSOFT_SUITE_v10_14_02

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 12, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis
Copy link
Copy Markdown
Contributor

aantonakis commented May 18, 2026

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02 #637 SBNSoftware/sbnobj#170 SBNSoftware/sbnanaobj#188

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@VCLanNguyen
Copy link
Copy Markdown
Contributor Author

VCLanNguyen commented May 19, 2026

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02 SBNSoftware/sbncode#637 SBNSoftware/sbnobj#170 SBNSoftware/sbnanaobj#188 SBNSoftware/sbndaq_artdaq_core@v1_10_06

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

❌ CI build for SBND Failed at phase setup_environment_cvmfs SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the setup_environment_cvmfs SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

❌ CI build for SBND Failed at phase setup_environment_cvmfs SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the setup_environment_cvmfs SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 19, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@VCLanNguyen
Copy link
Copy Markdown
Contributor Author

VCLanNguyen commented May 20, 2026

trigger build LArSoft/larcore@LARSOFT_SUITE_v10_14_02 LArSoft/larcorealg@LARSOFT_SUITE_v10_14_02 LArSoft/larcoreobj@LARSOFT_SUITE_v10_14_02 LArSoft/lardataalg@LARSOFT_SUITE_v10_14_02 LArSoft/lardataobj@LARSOFT_SUITE_v10_14_02 LArSoft/larfinder@LARSOFT_SUITE_v10_14_02 LArSoft/larsoftobj@LARSOFT_SUITE_v10_14_02 LArSoft/larvecutils@LARSOFT_SUITE_v10_14_02 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_14_02 LArSoft/larpandoracontent@LARSOFT_SUITE_v10_14_02 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbncode#637 SBNSoftware/sbnobj#170 SBNSoftware/sbnanaobj#188 SBNSoftware/sbnalg@v10_14_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbndata@v01_08 SBNSoftware/sbndutil@v10_06_01 SBNSoftware/sbnd_data@v01_41_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 20, 2026

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 20, 2026

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 20, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented May 20, 2026

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrilloAtWork PetrilloAtWork PetrilloAtWork approved these changes

@aliciavr aliciavr aliciavr approved these changes

@lynnt20 lynnt20 lynnt20 approved these changes

@asanchezcastillo asanchezcastillo Awaiting requested review from asanchezcastillo

@henrylay97 henrylay97 Awaiting requested review from henrylay97

@JosiePaton JosiePaton Awaiting requested review from JosiePaton

Assignees

@aliciavr aliciavr

@henrylay97 henrylay97

@lynnt20 lynnt20

@VCLanNguyen VCLanNguyen

@asanchezcastillo asanchezcastillo

Labels

breaking change caf Common analysis framework crt Cosmic Ray Tagger data features for data processing pds Photon Detection System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@VCLanNguyen @aantonakis @PetrilloAtWork @FNALbuild @aliciavr @lynnt20 @henrylay97 @asanchezcastillo