Fips sample module#1196
Open
rpanackal wants to merge 17 commits into
Open
Conversation
Assumptions - Only changes memory representation of key. - Key never serialized and directly passed to SSLContextBuilder.loadKeyMaterial which accepts any.
- Only change internal representation and directly forwared to apache SSLContextBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This change moves the FIPS regression test out of
connectivity-apache-httpclient4into a dedicated non-release sample module presented inPreviously, the
fips-approvedsetup inconnectivity-apache-httpclient4used profile based isolation.Feature scope:
connectivity-fips-sampleFipsProviderTestfromconnectivity-apache-httpclient4/src/test-fipsinto the new modulebc-fips,bcpkix-fips) and exclusion of non-FIPS BC jars-Dorg.bouncycastle.fips.approved_only=trueDefinition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated