[PULL REQUEST] Preparations for 2025 run#254
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the codebase for the 2025 Estimates run by extending the allowed configuration year range, suppressing pandas NA comparison warnings in the ASE module, and standardizing max_lookback=2 for EDD point-level fallback queries in the employment module.
Changes:
- Extend
InputParseryear bounds to allow 2025 inrun.end_year/debug.year. - Add explicit
notna()guards aroundmin_age/max_agecomparisons in_create_aseto avoid pandas RuntimeWarnings. - Set
max_lookback=2on EDD point-level fallback queries (get_naics72_split,xref_block_to_mgra); reduce the former from 3 to 2 to match the new convention.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/parsers.py | Bumps the validated year range upper bound from 2024 to 2025. |
| python/ase.py | Adds explicit NA checks to special-MGRA age restriction comparison to prevent RuntimeWarnings. |
| python/employment.py | Aligns EDD point-level fallback max_lookback to 2 for NAICS-72 split and block-to-MGRA crosswalk queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GregorSchroeder
added
bug
bryce-sandag
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this pull request. What changes are being made?
Updates InputParser to allow for year 2025 to be run in the configuration file.
Adds explicit NA handling to pandas comparison in A/S/E module to avoid RunTimeWarnings.
Updates max_lookback parameter for CA EDD Point dataset queries.
What issues does this pull request address?
closes #251
closes #252
closes #253
Additional context
This is the final preparation commit for an Estimates 2025 run. A release should be cut to make an official run and send to QA once the 2025 Group Quarters layer is ready.