Fix duplicated streaming frames on terminals without in-place redraw - #175
Merged
Conversation
auto_stream_mode fell back to 'live' (in-place cursor-up redraw) for any unrecognized terminal; where that erase does not take effect (tmux/screen, plain xterm, unknown PTYs) every frame appended instead of overwriting, reprinting the response's first line hundreds of times. - Allowlist the risky 'live' tier: only positively-recognized capable emulators get it; everything else fails safe to append-only 'commit' (issues no cursor movement, so it can never duplicate frames). - Force 'commit' under tmux/screen even on a capable outer terminal. - Default module _STREAM_MODE to 'commit' so entry points that never call set_stream_mode stay safe too. 'live' remains available via config. - Update/extend tests; full suite green (2574 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto_stream_mode fell back to 'live' (in-place cursor-up redraw) for any unrecognized terminal; where that erase does not take effect (tmux/screen, plain xterm, unknown PTYs) every frame appended instead of overwriting, reprinting the response's first line hundreds of times.