Skip to content

Classification grouping - clean up groupings when classifications are deleted #1776 #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davmlaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Classification grouping - clean up groupings when classifications are deleted #1776 #1777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions classification/signals/classification_hooks_grouping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,13 @@ def condition_set(sender, classification: Classification, **kwargs):
@receiver(pre_delete, sender=Classification)
def deleting_classification(sender, instance: Classification, **kwargs): # pylint: disable=unused-argument
# CLASSIFICATION DELETED
# when a classification is deleted, it will delete the corresponding ClassificationGroupingEntry
# so we need to mark the Allele Origin grouping (which dirty up does)
# delete the ClassificationGroupingEntry now (rather than waiting for the cascade) so the
# recalculation below doesn't count the classification being deleted - otherwise the grouping
# would be re-saved as clean while still including it, leaving a stale grouping behind
if entry := ClassificationGroupingEntry.objects.filter(classification=instance).first():
entry.dirty_up()
grouping = entry.grouping
entry.delete()
grouping.dirty_up()
_instant_undirty_check()


Expand Down
Loading