Update medicine.yml - #1474
Conversation
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughОбновлены балансы и условия срабатывания в ChangesБалансировка реагентов medicine.yml
Estimated code review effort: 4 (Complex) | ~60 минут Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Resources/Prototypes/Reagents/medicine.yml (1)
946-969: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winНе переводить этот урон на
groups: Brute— эта форма размажет значение поBlunt,Slash,PiercingиArmorPiercing, и передозировка начнёт проходить через броню иначе, чем чистыйBlunt. Если прежнее поведение важно, оставьтеtypes: Blunt.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Reagents/medicine.yml` around lines 946 - 969, The Ultravasculine overdose damage is using groups: Brute, which redistributes the damage across multiple damage types and changes armor interaction. In the Ultravasculine entries in medicine.yml, update the overdose health change definition to use the original blunt damage type instead of the Brute group, and keep the existing HealthChange/EvenHealthChange conditions intact so the behavior matches the intended pre-change handling.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Resources/Prototypes/Reagents/medicine.yml`:
- Around line 946-969: The Ultravasculine overdose damage is using groups:
Brute, which redistributes the damage across multiple damage types and changes
armor interaction. In the Ultravasculine entries in medicine.yml, update the
overdose health change definition to use the original blunt damage type instead
of the Brute group, and keep the existing HealthChange/EvenHealthChange
conditions intact so the behavior matches the intended pre-change handling.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5431de5d-cc95-4319-9cf1-467085da8a36
📒 Files selected for processing (1)
Resources/Prototypes/Reagents/medicine.yml
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
Resources/Prototypes/Reagents/medicine.yml (2)
1346-1363: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winРазведите пороги
TotalDamageConditionВ
Resources/Prototypes/Reagents/medicine.ymlпервая ветка (min: 199.9) остаётся истинной и при>= 500, поэтому обаEvenHealthChangeсрабатывают вместе и дают суммарноBrute/Burn: -6/-6. Если нужен именно переход на-4/-4, добавьтеmaxв первую ветку.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Reagents/medicine.yml` around lines 1346 - 1363, The two EvenHealthChange branches in the medicine reagent prototype overlap because the first TotalDamageCondition with min 199.9 also matches values at and above 500, so both effects apply together. Update the conditions in the medicine.yml prototype so the lower-damage branch is bounded with a max value and only the higher-damage branch (the one paired with the 500 threshold) remains active above that range, using the existing EvenHealthChange and TotalDamageCondition symbols to locate the section.
204-217: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winРазделите
AdjustTraumasна два пункта спискаВ одном
!type:AdjustTraumasповторяютсяtraumaType,amount,identifierиtargetBodyParts, поэтомуBoneDamageбудет потерян. Нужны два отдельных элемента списка.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/Prototypes/Reagents/medicine.yml` around lines 204 - 217, The Cryoxadone reagent entry is combining two trauma adjustments into one !type:AdjustTraumas block, which causes the first trauma settings to be overwritten. Split this into two separate list items under the medicine prototype so each AdjustTraumas instance has its own traumaType, amount, identifier, and targetBodyParts values; use the existing Cryoxadone and AdjustTraumas symbols to locate and separate the BoneDamage and OrganDamage effects.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Resources/Prototypes/Reagents/medicine.yml`:
- Around line 1346-1363: The two EvenHealthChange branches in the medicine
reagent prototype overlap because the first TotalDamageCondition with min 199.9
also matches values at and above 500, so both effects apply together. Update the
conditions in the medicine.yml prototype so the lower-damage branch is bounded
with a max value and only the higher-damage branch (the one paired with the 500
threshold) remains active above that range, using the existing EvenHealthChange
and TotalDamageCondition symbols to locate the section.
- Around line 204-217: The Cryoxadone reagent entry is combining two trauma
adjustments into one !type:AdjustTraumas block, which causes the first trauma
settings to be overwritten. Split this into two separate list items under the
medicine prototype so each AdjustTraumas instance has its own traumaType,
amount, identifier, and targetBodyParts values; use the existing Cryoxadone and
AdjustTraumas symbols to locate and separate the BoneDamage and OrganDamage
effects.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 80aecb6c-30c5-473c-92b2-c3d4c41b25da
📒 Files selected for processing (1)
Resources/Prototypes/Reagents/medicine.yml
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 participant
Summary by CodeRabbit