Conversation
There was a problem hiding this comment.
Pull request overview
Adds new Minimax Music 2.6 request options by extending existing request payload dataclasses in runware/types.py, enabling callers to pass new audio-generation tuning parameters through the SDK’s typed interfaces.
Changes:
- Extend
ISettingswithinstrumentalandlyricsOptimizer. - Extend
IAudioInferencewithoutputQuality.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| lyricsOptimizer: Optional[bool] = None | ||
| guidanceType: Optional[str] = None | ||
| textNormalization: Optional[bool] = None | ||
| topK: Optional[int] = None |
There was a problem hiding this comment.
ISettings defines topK twice (here in the Audio section and again later in the Text section). In a dataclass/class body, the later definition overwrites the earlier one, so the audio topK value can never be set/serialized as intended. Consider renaming these fields to be modality-specific (e.g., audioTopK/textTopK) or splitting settings into nested structs to avoid silent overrides (same issue also exists for other duplicated names like thinking).
| topK: Optional[int] = None | |
| audioTopK: Optional[int] = None |
Added
ISettingsnow includes:instrumental: Optional[bool]lyricsOptimizer: Optional[bool]IAudioInferencenow includes:outputQuality: Optional[int]