Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Sync 3 model support by extending the SDK’s typed request structures and normalization logic for Sync-related video settings.
Changes:
- Expanded
ISettingsandISyncProviderSettingswith Sync 3 fields (mode/emotion/active speaker detection/occlusion/segments). - Introduced
ISegmentandIActiveSpeakerDetection(withboundingBoxesvalidation) and added backward-compatible aliases. - Added
__post_init__coercion so dict inputs are normalized into typed objects.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ISettings:syncMode: Optional[str]mode: Optional[str]emotion: Optional[str]activeSpeakerDetection: Optional[Union[IActiveSpeakerDetection, Dict[str, Any]]]occlusionDetection: Optional[bool]segments: Optional[List[Union[ISegment, Dict[str, Any]]]]tts: Optional[Union[ITTSSettings, Dict[str, Any]]]IActiveSpeakerDetection(autoDetect,frameNumber,coordinates,boundingBoxes) with validation forboundingBoxesentries (nullor four numeric values).ISegmentfor Sync segments (startTime,endTime,audio,ref,audioStartTime,audioEndTime).ITTSSettingsfor Sync TTS tuning (stability,similarityBoost).ISyncSegment = ISegmentISyncActiveSpeakerDetection = IActiveSpeakerDetectionISyncSettings = ISyncProviderSettingsChanged
ISyncProviderSettingsto include Sync 3 fields:mode: Optional[str]emotion: Optional[str]activeSpeakerDetection: Optional[Union[IActiveSpeakerDetection, Dict[str, Any], bool]]occlusionDetection: Optional[bool]segments: Optional[List[Union[ISegment, Dict[str, Any]]]]post_initnormalization for Sync settings so dictionary inputs are coerced toIActiveSpeakerDetection/ISegment/ITTSSettingsobjects.