Codex/full e2e coverage campaign#1116
Open
jeffscottward wants to merge 598 commits into
Open
Conversation
added 30 commits
June 17, 2026 13:36
added 24 commits
June 17, 2026 15:19
|
Too many files changed for review. ( |
|
Important Review skippedToo many files! This PR contains 959 files, which is 809 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (959)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Collaborator
|
Hi @jeffscottward - thank you for the enormous effort on this e2e coverage campaign! The breadth of new tests and docs here is genuinely impressive and exactly the kind of long-term investment that pays off. 🙏 I took a pass and there are a couple of things to sort out before this can be approved and merged: 1. This looks like prettier choking on the very large files this PR adds. The prime suspect is
Merges here are gated on passing CI, so this one needs to go green. 2. The PR is too large for our automated reviewers (please consider scoping down). At 908 files and ~523k added lines, both Greptile ( Good news: there are no merge conflicts, so no rebase is needed on that front. Once the lint check is green (and ideally the scope is trimmed a bit), give me a ping and I'll take another pass. Thanks again for all the work here! |
Contributor
Author
|
@RazaHabib I pushed my latest local work to this PR in |
Contributor
|
@jeffscottward this is some nice work. Can you kindly fix the conflicts and prepare the PR for a final review so that I can merge this in |
Contributor
Author
@reachrazamair I'm not working on the project anymore as I've shifted to Oh-My-Pi. All you have to do is check out the branch and set a /goal to rebase and get to full green check passing on the ci and let it run. My ai's are already running against OMP and don't have bandwidth to do this. You might also ask @pedramamini I know he has multiple accounts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latest test campaign. see docs/testing