Optional FAQID param in FAQSearch function.#64
Open
stefane2741 wants to merge 1 commit into
Open
Conversation
|
|
||
| ServiceID => $ServiceID, # (optional) | ||
|
|
||
| # Use FAQSearch as an FAQ filter on a single FAQ item, |
Contributor
There was a problem hiding this comment.
*a FAQ, if I am not mistaken
Contributor
Author
There was a problem hiding this comment.
It would depend on how the word FAQ sounds phonetically, not necessarily how it's spelled.
I figured it starts with a pronounced "eff..." and so it is preceded by an "an". :)
|
|
||
| # Limit the search to just one (or a list) FAQID (used by the otobo-ai package | ||
| # to filter for events on single FAQ items with the job's FAQ filter). | ||
| if ( IsStringWithData( $Param{FAQID} ) || IsArrayRefWithData( $Param{FAQID} ) ) { |
Contributor
There was a problem hiding this comment.
IsInteger would be more suitable as you are later quoting it as Integer
Contributor
Author
There was a problem hiding this comment.
This sounds good to me. Maybe it's worth considering changing it in Kernel::System::Ticket::TicketSearch aswell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.