Apply Rule of Zero to empty destructors across core/

[lyskov-ai]

Summary

Move trivially empty (~X() {}) or = default;-bodied destructors from .cc files to header declarations using = default, and remove the now-redundant .cc implementations. Where a destructor was declared ~X() {} inline in a header, switch it to ~X() = default; for the same reason.

This unlocks the implicit move-special-members the user-declared destructors were suppressing and removes pure-noise boilerplate.

Affected sibling groups

• core/conformation/membrane/{AqueousPoreParameters, ImplicitLipidInfo, MembraneGeometry, MembraneInfo} and membrane_geometry/{Bicelle, DoubleVesicle, Slab, Vesicle} — 8 classes
• core/conformation/parametric/{Boolean, Real, RealVector, Size, SizeVector}ValuedParameter — 5 classes
• core/io/silent/SilentFileData::{iterator, const_iterator} — inline empty dtors removed
• core/pack/interaction_graph/RotamerDots.{hh,cc} — DotSphere, RotamerDots, RotamerDotsCache, InvRotamerDots
• core/scoring/etable/EtableEnergy.{hh,cc} — EtableEvaluator, AnalyticEtableEvaluator, TableLookupEvaluator
• core/scoring/hbonds/graph/HBondInfo.hh — LKHBondInfo, HBondInfo (also removed an unused user-defined empty copy ctor on LKHBondInfo)
• core/scoring/nmr/NMRDummySpinlabelVoxelGrid.{hh,cc} — VoxelGridPoint, NMRDummySpinlabelAtom, VoxelGridPoint_AA, NMRDummySpinlabelVoxelGrid
• core/scoring/sc/MolecularSurfaceCalculator::Atom
• core/energy_methods/SAXSEnergy

No behavior changes — pure code-style refactor.

[roccomoretti]

Fine as far as it goes, but putting ~Class() override = default is unnecessary, as the only benefit of declaring a default destructor is being able to label it virtual. (Which it already has to be with the override.)

IIRC, the "unlocks the implicit move-special-members" isn't quite correct -- explicitly defaulting the destructor still counts as "user defined" for the purposes of suppressing the implicit move functions. (Which is why just leaving it off is typically preferred.)