Skip to content

Fix rating popup JS errors #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hcooper merged 1 commit into from
Apr 24, 2026
Merged

Fix rating popup JS errors #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webserver/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ RUN cd /rw/extensions/PageForms && patch -l -p0 < PF_FormPrinter.php.$MW_REL_BRA
# (prevents auto-filled destination filename from being overwritten by uploaded file's name)
RUN cd /rw/extensions/PageForms && patch -l -p0 < PF_upload.js.$MW_REL_BRANCH.patch

# Apply PageForms patch to fix missing 'pf' dependency in rating module
# (adds ext.pageforms dependency to ext.pageforms.rating module to prevent "pf is not defined" error)
RUN cd /rw/extensions/PageForms && patch -l -p0 < extension.json.$MW_REL_BRANCH.patch

# Sphinx: Setup cron job
RUN apt-get install -y cron \
&& mv -f /rw/extensions/SphinxSearch/sphinx.cron /etc/cron.d/sphinxsearch-update \
Expand Down
12 changes: 12 additions & 0 deletions webserver/html/ropewiki/extensions/PageForms/extension.json.REL1_39.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- extension.json 2026-04-21 14:30:13.653018861 -0700
+++ extension.json 2026-04-21 14:31:15.113484589 -0700
@@ -339,6 +339,9 @@
"scripts": [
"libs/jquery.rateyo.js",
"libs/PF_rating.js"
+ ],
+ "dependencies": [
+ "ext.pageforms"
]
},
"ext.pageforms.rating.styles": {
Loading