Fix compile errors, due to not finding the path in the React module#30
Closed
JuriaanGregor wants to merge 1 commit into
Closed
Fix compile errors, due to not finding the path in the React module#30JuriaanGregor wants to merge 1 commit into
JuriaanGregor wants to merge 1 commit into
Conversation
JuriaanGregor
had a problem deploying
to
integration
GitHub Actions
Failure
Collaborator
|
I think the proposed fix here might not be compatible with our internal tooling. I'll investigate further to determine what's causing the project hierarch to be different for wally installation |
Collaborator
|
Closing this as well per: #29 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Roblox team,
The following PR resolves #29, currently a clean wally install causes the React module to fail since it can't find the required modules.
This doesn't happen in the test suite, but it does happen on production (= the wally install)
After the PR the result of the include is the following:
