Skip to content

Add support for retrieve catalog nodes#62

Merged
giladwolff merged 7 commits into
mainfrom
gw/add-get-nodes
Jun 18, 2025
Merged

Add support for retrieve catalog nodes#62
giladwolff merged 7 commits into
mainfrom
gw/add-get-nodes

Conversation

@giladwolff

@giladwolff giladwolff commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

What problem are we solving?

Currently there is no support for the Consul List-Nodes HTTP API.

How are we solving the problem?

Added a get_nodes API that accepts a GetNodesRequest and returns a GetNodesResponse with a vector of CatalogNodes. The api is based on the Consul HTTP API with a few changes:

  • We don't expose the deprecated NodeMeta option, and force clients to use the new filter Meta selector.
  • We don't expose partition, as it is only available in the enterprise edition and can be deduced by the ACL.

As part of this change I added a test and to make it easier to test locally I made all tests clean after themselves so that as long as there is no intermediate failures tests can be run again and again.

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

@github-actions

Copy link
Copy Markdown

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@giladwolff

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@giladwolff giladwolff changed the title Working with tests Add support for retrieve catalog nodes Jun 17, 2025
@giladwolff giladwolff marked this pull request as ready for review June 17, 2025 22:36
@giladwolff giladwolff requested a review from kushudai June 17, 2025 22:36
Comment thread src/lib.rs Outdated
@giladwolff giladwolff requested a review from x0rw June 18, 2025 22:34
Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Co-authored-by: Kushagra Udai <112903599+kushudai@users.noreply.github.com>
@giladwolff giladwolff requested a review from kushudai June 18, 2025 22:39
Comment thread testdata/config.hcl Outdated
@giladwolff giladwolff merged commit 342360f into main Jun 18, 2025
5 checks passed
@giladwolff giladwolff deleted the gw/add-get-nodes branch June 18, 2025 22:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants