Add support for retrieve catalog nodes#62
Merged
Merged
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
x0rw
suggested changes
Jun 18, 2025
kushudai
reviewed
Jun 18, 2025
Co-authored-by: Kushagra Udai <112903599+kushudai@users.noreply.github.com>
kushudai
approved these changes
Jun 18, 2025
kushudai
reviewed
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Currently there is no support for the Consul List-Nodes HTTP API.
How are we solving the problem?
Added a get_nodes API that accepts a GetNodesRequest and returns a GetNodesResponse with a vector of CatalogNodes. The api is based on the Consul HTTP API with a few changes:
As part of this change I added a test and to make it easier to test locally I made all tests clean after themselves so that as long as there is no intermediate failures tests can be run again and again.
Checks
Please check these off before promoting the pull request to non-draft status.