feat(dynamics): measurable model-strategy risk certificates - #144
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughSummaryThe PR adds exact singular-fraction optimization, continuous sleeping-strategy PAC-Bayes bounds, two-sided event theorems, measurable-trajectory specializations, umbrella imports, documentation updates, and declaration-checking examples. ChangesPAC-Bayes extensions
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: ⚪ Minimal · up to This PR adds formally verified model-strategy risk certificates and related documentation without introducing a supported merge-blocking correctness, security, availability, or deployment risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant TrajectoryEvent
participant TwoSidedPACBayes
participant ExactOptimizer
TrajectoryEvent->>TwoSidedPACBayes: supply trajectory measurability and adaptation
TwoSidedPACBayes->>TwoSidedPACBayes: intersect original and complemented events
TwoSidedPACBayes->>ExactOptimizer: select canonical optimal lambda
ExactOptimizer-->>TrajectoryEvent: provide exact optimized boundary
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99c067f8ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| omit [MeasurableSpace Theta] in | ||
| /-- The active-strategy posterior log value is exactly the weighted | ||
| conditional-minus-observed score minus the predictor quadratic penalty. -/ | ||
| theorem continuousTrajectoryCountableSleeping_activeLogValue_eq |
There was a problem hiding this comment.
Register the decomposition theorems in the checker
Neither this public theorem nor the following integral_continuousTrajectoryCountableSleeping_activeLogValue theorem has a #check or #print axioms entry in examples/CheckContinuousMeasurableTrajectoryCountableSleepingStrategyOrdinaryRiskPACBayes.lean. As a result, example verification does not guard these newly exported score-decomposition bridges against signature or axiom-set regressions; add both declarations to the checker and confirm the sanctioned public axiom set.
AGENTS.md reference: AGENTS.md:L54-L59
Useful? React with 👍 / 👎.
Summary
The reporting time, eligible model posterior, and posterior on the active strategy prefix may be selected from the observed path on the same common event.
Scope
This is confidence allocation over a countable predictable-strategy catalog fixed before observation. It is not coin betting or competition with every legal predictable strategy. The ordinary endpoint concerns conditional risk encountered on the monitored prefix; it is not future, stationary, population, or deployment risk. The exact scalar-fraction optimizer is a mathematical optimum, not an executable selector.
Verification
~/.elan/bin/lake -Kjobs=2 build FormalSLT— passed, 4,096 jobsexamples/*.lean— passed sequentially[propext, Classical.choice, Quot.sound]sorry,admit, or custom axiom declarationsgit diff --check origin/main...HEAD— passedSummary by CodeRabbit
New Features
Documentation