Improve ride controls, session history, and device pairing#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous single-device connection flow could not represent multiple independent sensors or Click controllers. Click notifications may also be duplicated across channels or mirrored across controller connections, so learning controller identity from whichever notification arrived first caused incorrect labels, double shifts, and misleading connection state. This change identifies physical sides from their Bluetooth manufacturer data, locks event routing to the matching side, and keeps each connection lifecycle independent.
User impact
Riders can manage all supported devices from one panel, reconnect remembered hardware automatically, use Click V2 for virtual shifting, and see gear data throughout live and saved sessions. Existing resistance-only sessions remain supported.
Validation
bun run ci