Support Elite and generic FTMS trainers#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The trainer chooser only accepted device names beginning with
KICKR, which excluded the Elite DIRETO XR-T before the shared FTMS implementation could run. Control writes also advanced after the BLE write completed instead of waiting for the FTMS control-point response, allowing stricter trainers to reject overlapping initialization commands.Impact
Ride Control can pair with standards-compliant FTMS trainers from multiple manufacturers while continuing to use one active trainer for a ride. Protocol rejections now report the trainer's actual FTMS result.
Validation
bun run ci