fix: make clone progress visible#439
Draft
YogliB wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What
Make clone progress visible during long-running
degitruns by emitting aCLONINGlifecycle event before work starts and delayingSUCCESSuntil all tar/post-clone work is complete.Why
Issue #220 reports that successful clones can look hung because the success line appears before the CLI is actually done.
Changes
CLONINGinfo event insrc/index.tsso the CLI can show that work has started.SUCCESSemission to the end of the clone flow so it reflects completion after tar extraction and post-clone directives.test/unit/index.test.tsthat provesCLONINGhappens before directive cleanup andSUCCESS.Testing
How you verified this (commands, scenarios, or N/A):
Focused unit tests:
bun run test test/unit/index.test.tsFocused unit tests:
bun run test test/unit/bin.test.tsCLI check:
node degit rollup/rollup rollupAutomated tests (
bun run test)Manual / CLI check if user-facing behavior changed
CI passes
Review notes
Breaking changes (or none)
None.
Risks / rollout (or none)
The new start event is intentionally minimal; the main risk is only output-order expectations in consumers that were implicitly relying on the earlier success line.
Focus areas for reviewers (optional)
src/index.tslifecycle orderingtest/unit/index.test.tsevent-order regression coverageChecklist