Skip to content

Edits to the Guided Sandbox to Address YB's comments - #18

Open
danieljfeller wants to merge 15 commits into
mainfrom
sandbox_edits
Open

Edits to the Guided Sandbox to Address YB's comments#18
danieljfeller wants to merge 15 commits into
mainfrom
sandbox_edits

Conversation

@danieljfeller

@danieljfeller danieljfeller commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Click here for the SDK renaming reference table

Adrish needs to do two things upon his return:
#1 Sandbox instances need to be pre-loaded with Chest X-rays (/rhino_data/image/dicom) and associated metadata ('/rhino_data/image/metadata/aidev_cohort.csv').
#2 Create a mechanism for “Dr. Jones” (Health System persona) to auto-accept project invitations. Users SHOULD NOT need to wait for a Rhino team member to approve their invitation to proceed with the Sandbox project.

A few things that I could use your help with @ori Ashush
#1 Replacing all container calls with General Compute where the sandbox user can see the Python doing the data transformation, model training, or evaluation. 🙏
#2 Fixing the image links. You’ll see screenshots in user-resources/sandbox/pneumonia-prediction/images/ If any image links in the notebooks are broken, please fix them. I tried and failed to do so. 🚨
#3 Yaron recommended changing all the settings for links to other rhino docs (e.g. FL, FCP, Project, etc.) so they open in a new tab rather than the same tab to reduce the risk of derailing the flow. I wasn't able to figure out how to do this 😢 so please help me if nothing else!
sandbox_overview
#4 Add Tensorboard to notebook #4 if you want to try it 🧠

@danieljfeller
danieljfeller requested a review from a user January 20, 2024 01:48
@ghost
ghost marked this pull request as draft January 23, 2024 14:57
@adrish-rhino

Copy link
Copy Markdown
Contributor

lgtm

@ghost

ghost commented Feb 15, 2024

Copy link
Copy Markdown

@adrish-rhino all yours for the final changes

@ghost
ghost marked this pull request as ready for review March 6, 2024 18:26

@yuvalrhino yuvalrhino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrish-rhino It's a bit hard for me to know what is actually going to be shown to users. I see some screenshots that still have the word "Cohort" in them, but then there's usually an equivalent version with "Dataset".
For notebooks - we usually clear outputs before putting this in the user-resources repo so that users don't see the outputs, execution count, etc. from when we ran the code.
Also - I'm assuming you've run this end to end to verify that it works properly, right?

@adrish-rhino

Copy link
Copy Markdown
Contributor

We have to fix few diagrams here and in zendesk. Drew tested it before, I would like Daniel to test one more time since the last test was in Feb. We added task in commercial sprint and have plan to complete this by May 17th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants