Skip to content

fix(profile): dispose stale ECharts instance in initEChart #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vahldiek merged 1 commit into from
Jul 15, 2026
Merged

fix(profile): dispose stale ECharts instance in initEChart #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/assets/js/reprodb-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@
R.initEChart = function(el) {
if (typeof el === 'string') el = document.getElementById(el);
if (!el) return null;
// Dispose any existing instance on this element so re-renders start from
// a clean slate. echarts.init otherwise returns the existing instance, and
// a subsequent setOption() merges by default — leaving stale series/data
// (e.g. a previous profile's "AE Committee Service" bars) behind when
// switching between people on the profile page.
var existing = echarts.getInstanceByDom(el);
if (existing) existing.dispose();
var chart = echarts.init(el, null, { renderer: 'canvas' });

// Wrap setOption so every call automatically re-applies theme text
Expand Down