feat(artists): mark as favorite

[KayBeSee]

closes #77

[KayBeSee]

Had a really hard time DRYing the relisten_favorites:artists variable to reuse in src/lib/serverFavoriteCookies.ts. It kept saying the export was a function?

Also open to changing naming convention. Figure it was worth scoping to artist so a different cookie name can be used for tracks.

[switz]

can you export the cookie key so its declared once and imported?

[KayBeSee]

Yup. I added to src/lib/constants.ts b/c was getting some weird behavior importing/exporting between client and server components.

[switz]

Is there any way we can make this work without calling router.refresh?

[switz]

Also might be better to use a Set here:

  const toggleFavorite = useCallback(
    (artistId: string) => {
      const updatedFavorites = new Set([...parsedCookies]);

      if (parsedCookies.includes(artistId)) {
        updatedFavorites.delete(artistId);
      } else {
        updatedFavorites.add(artistId);
      }

      setFavorites([...updatedFavorites]);
    },
    [parsedCookies, setFavorites]
  );

[KayBeSee]

Also might be better to use a Set here:

  const toggleFavorite = useCallback(
    (artistId: string) => {
      const updatedFavorites = new Set([...parsedCookies]);

      if (parsedCookies.includes(artistId)) {
        updatedFavorites.delete(artistId);
      } else {
        updatedFavorites.add(artistId);
      }

      setFavorites([...updatedFavorites]);
    },
    [parsedCookies, setFavorites]
  );

Good call, just updated.

Is there any way we can make this work without calling router.refresh?

I can mess around with it for sure. I was doing router.refresh based on this comment in the original issue.

[switz]

yeah that's my bad, didn't think to realize it would also refetch the random shows.