feat: enable status banner via same-origin /serverinfo.json - #7
Merged
Conversation
The status banner has been showing "server status unavailable (endpoint not configured)" since launch. The serverinfo.json producer (serverinfo-updater) and the same-origin proxy on reduxstation.com (via infrastructure/docker/caddy/Caddyfile) are both running, so the website just needs to point at the endpoint. - _data/site.yaml: status_endpoint = "/serverinfo.json" - _data/servers.yaml: identifier "redux" -> "reduxstation" so it matches what serverinfo-updater writes (SERVER_IDENTIFIER from globals.env). gamebanners.js renderBanner does document.getElementById(server.identifier), so the id must match exactly or the banner stays in error state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two-line wiring change so the status banner stops showing
"server status unavailable (endpoint not configured)":
(same-origin path, no CORS).
`reduxstation` so the banner element id matches what
`serverinfo-updater` writes for `identifier`. `gamebanners.js`
does `document.getElementById(server.identifier)`, so the two
must match exactly or the banner stays in error state.
Companion PR
`ReduxStation/infrastructure#2` adds the matching `handle /serverinfo.json`
reverse-proxy on the production Caddy. That has to land + Caddy be
recreated before this PR will show live player counts; until then the
banner falls into `setNetworkError` and reads "connection error" instead
of "endpoint not configured".
After both PRs merge