Update Linux CI workflow to use GODOT_CPP_BRANCH 4.5#1256
Conversation
WalkthroughThe Linux builds workflow updates ChangesLinux workflow branch updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
It is because there is no 4.5 branch on the Redot GDExtension fork. Testing some stuff locally to make sure #1250 should pass after merging this PR. |
Arctis-Fireblight
force-pushed
the
bump-godotcpp
branch
from
8ade501 to
2e435e3
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/linux_builds.yml:
- Line 170: Replace the moving ref "master" for the redot-cpp-branch input with
a stable identifier: either pin a specific commit SHA from the
redot-engine/redot-cpp repo or create/use a fixed branch name that matches the
workflow's GODOT_CPP_BRANCH (e.g., "4.5") pattern; update the value of
redot-cpp-branch to that commit SHA or the new branch name so the CI path is
reproducible and not affected by upstream changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 34d1f586-a579-4cb2-a091-a21260ed87a2
📒 Files selected for processing (1)
.github/workflows/linux_builds.yml
| bin: ${{ matrix.bin }} | ||
| scons-flags: target=template_debug dev_build=yes verbose=yes | ||
| redot-cpp-branch: ${{ env.GODOT_CPP_BRANCH }} | ||
| redot-cpp-branch: "master" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the composite action to confirm repository + branch input wiring.
action_file="$(fd -HI 'action.yml' .github/actions/redot-cpp-build | head -n1)"
echo "Action file: ${action_file}"
sed -n '1,220p' "${action_file}"
echo
rg -n -C2 'redot-cpp|repo|repository|git clone|branch' "${action_file}"
# Verify branch availability on the redot-cpp fork.
for branch in 4.5 master; do
echo
echo "Checking redot-engine/redot-cpp branch: ${branch}"
curl -fsS "https://api.github.com/repos/redot-engine/redot-cpp/branches/${branch}" \
| jq -r '.name // "missing"'
doneRepository: Redot-Engine/redot-engine
Length of output: 1878
🏁 Script executed:
#!/bin/bash
# Check master branch independently
echo "Checking redot-engine/redot-cpp branch: master"
curl -s "https://api.github.com/repos/redot-engine/redot-cpp/branches/master" | jq -r '.name // "missing"'
# Also check what branches are available
echo
echo "Available branches on redot-engine/redot-cpp (sample):"
curl -s "https://api.github.com/repos/redot-engine/redot-cpp/branches?per_page=10" | jq -r '.[].name'Repository: Redot-Engine/redot-engine
Length of output: 194
🏁 Script executed:
#!/bin/bash
# Check the workflow file context around line 170
sed -n '160,180p' .github/workflows/linux_builds.yml
echo
# Also check for other uses of redot-cpp-branch in the file
rg -n 'redot-cpp-branch' .github/workflows/linux_builds.ymlRepository: Redot-Engine/redot-engine
Length of output: 799
🏁 Script executed:
#!/bin/bash
# Find GODOT_CPP_BRANCH definition
rg -n 'GODOT_CPP_BRANCH' .github/workflows/linux_builds.yml | head -20
echo
# Check the env section of the workflow
sed -n '1,50p' .github/workflows/linux_builds.ymlRepository: Redot-Engine/redot-engine
Length of output: 2062
Use a stable ref for redot-cpp-branch instead of master.
Hardcoding to master creates a moving target that makes this CI path non-reproducible and can cause unrelated test failures if upstream changes. While the 4.5 branch doesn't currently exist on redot-engine/redot-cpp, consider using a commit SHA for stability or creating the 4.5 branch to match the GODOT_CPP_BRANCH: 4.5 pattern used elsewhere in the workflow.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/linux_builds.yml at line 170, Replace the moving ref
"master" for the redot-cpp-branch input with a stable identifier: either pin a
specific commit SHA from the redot-engine/redot-cpp repo or create/use a fixed
branch name that matches the workflow's GODOT_CPP_BRANCH (e.g., "4.5") pattern;
update the value of redot-cpp-branch to that commit SHA or the new branch name
so the CI path is reproducible and not affected by upstream changes.
2 participants
Update the workflows to test against GDExtension 4.5 instead of 4.4.
Summary by CodeRabbit