refactor: update DataVolume resource with type hints and extended spec support by ema-aka-young · Pull Request #2708 · RedHatQE/openshift-python-wrapper

ema-aka-young · 2026-05-05T15:05:45Z

Manual Cherry-pick from main branch, original PR: #2480, PR owner: jpeimer

https://redhat.atlassian.net/browse/CNV-86647

coderabbitai · 2026-05-05T15:05:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 27d8f6da-c13e-44bd-ab7c-6221d45ccc1e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ema-aka-young · 2026-05-05T15:08:20Z

/wip

redhat-qe-bot2 · 2026-05-05T15:08:24Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: Disabled for this repository
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest python-module-install - Test Python package installation
/retest conventional-title - Validate commit message format
/retest all - Run all available tests

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

myakove
rnetser

Reviewers:

dbasunag
myakove
rnetser

Available Labels

hold
verified
wip
lgtm
approve
automerge

AI Features

Conventional Title: Mode: fix (claude/claude-opus-4-6[1m])
Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

ema-aka-young · 2026-05-05T15:11:56Z

/wip

redhat-qe-bot2 · 2026-05-08T08:40:21Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: Disabled for this repository
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest python-module-install - Test Python package installation
/retest conventional-title - Validate commit message format
/retest all - Run all available tests

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

myakove
rnetser

Reviewers:

dbasunag
myakove
rnetser

Available Labels

hold
verified
wip
lgtm
approve
automerge

AI Features

Conventional Title: Mode: fix (claude/claude-opus-4-6[1m])
Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

ema-aka-young · 2026-05-08T08:41:11Z

Main backported file. Other changes are format fixes to make tox pass.

@ema-aka-young what failed? did a local backport and no changes were needed

@rnetser When running tox, I got failures with the class generator...

https://github.com/RedHatQE/openshift-python-wrapper/pull/2708/checks?check_run_id=74392070481

the changes from #2702 are needed - will backport

ema-aka-young · 2026-05-11T14:57:00Z

/verified
with RedHatQE/openshift-virtualization-tests#4758

rnetser

#2720 is merged; please rebase
only the files from the original PR should exist, or - preferabily - close this one and cherrypick from the original pr

ema-aka-young · 2026-05-14T13:28:26Z

Closing in favor of #2723

jpeimer and others added 2 commits May 5, 2026 13:04

refactor: update DataVolume resource (RedHatQE#2480)

598ae3a

Fix tox applying updated ruff formatting

ed1558c

ema-aka-young mentioned this pull request May 5, 2026

WIP: CherryPicked: [v4.19] refactor: update DataVolume resource #2707

Closed

ema-aka-young marked this pull request as ready for review May 5, 2026 15:07

redhat-qe-bot2 requested a review from myakove May 5, 2026 15:08

redhat-qe-bot2 assigned ema-aka-young May 5, 2026

redhat-qe-bot2 requested a review from dbasunag May 5, 2026 15:08

redhat-qe-bot2 added branch-v4.19 size/L labels May 5, 2026

redhat-qe-bot2 requested a review from rnetser May 5, 2026 15:08

rh-bot-1 added the wip label May 5, 2026

rh-bot-1 changed the title ~~[v4.19] refactor: update DataVolume resource~~ WIP: [v4.19] refactor: update DataVolume resource May 5, 2026

redhat-qe-bot2 changed the title ~~WIP: [v4.19] refactor: update DataVolume resource~~ refactor: update DataVolume resource May 5, 2026

redhat-qe-bot2 removed the wip label May 5, 2026

ema-aka-young changed the title ~~refactor: update DataVolume resource~~ [4.19] refactor: update DataVolume resource May 5, 2026

rh-bot-1 added the wip label May 5, 2026

rh-bot-1 changed the title ~~[4.19] refactor: update DataVolume resource~~ WIP: [4.19] refactor: update DataVolume resource May 5, 2026

redhat-qe-bot2 changed the title ~~WIP: [4.19] refactor: update DataVolume resource~~ refactor: update DataVolume resource May 5, 2026

redhat-qe-bot removed the wip label May 5, 2026

ema-aka-young marked this pull request as draft May 5, 2026 15:25

ema-aka-young changed the title ~~refactor: update DataVolume resource~~ [4.19] refactor: update DataVolume resource May 6, 2026

ema-aka-young mentioned this pull request May 6, 2026

WIP: [4.19] Add support for datasources + backport online resize tests RedHatQE/openshift-virtualization-tests#4758

Open

ema-aka-young marked this pull request as ready for review May 8, 2026 08:39

redhat-qe-bot2 changed the title ~~[4.19] refactor: update DataVolume resource~~ refactor: update DataVolume resource May 8, 2026

ema-aka-young commented May 8, 2026

View reviewed changes

rh-bot-1 added the commented-ema-aka-young label May 8, 2026

ema-aka-young changed the title ~~refactor: update DataVolume resource~~ [4.19] refactor: update DataVolume resource May 11, 2026

redhat-qe-bot1 added the verified label May 11, 2026

redhat-qe-bot changed the title ~~[4.19] refactor: update DataVolume resource~~ refactor: update DataVolume resource with type hints and extended spec support May 11, 2026

redhat-qe-bot1 added the commented-rnetser label May 12, 2026

rh-bot-1 added the has-conflicts label May 14, 2026

rnetser requested changes May 14, 2026

View reviewed changes

redhat-qe-bot1 added the changes-requested-rnetser label May 14, 2026

ema-aka-young closed this May 14, 2026

Conversation

ema-aka-young commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ema-aka-young commented May 5, 2026

Uh oh!

redhat-qe-bot2 commented May 5, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

ema-aka-young commented May 5, 2026

Uh oh!

redhat-qe-bot2 commented May 8, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

ema-aka-young May 8, 2026

Choose a reason for hiding this comment

Uh oh!

rnetser May 12, 2026

Choose a reason for hiding this comment

Uh oh!

ema-aka-young May 12, 2026

Choose a reason for hiding this comment

Uh oh!

ema-aka-young May 12, 2026

Choose a reason for hiding this comment

Uh oh!

rnetser May 12, 2026

Choose a reason for hiding this comment

Uh oh!

ema-aka-young commented May 11, 2026

Uh oh!

rnetser left a comment

Choose a reason for hiding this comment

Uh oh!

ema-aka-young commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ema-aka-young commented May 5, 2026 •

edited

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading