Skip to content

Remove unused jira-escalation command and SlackClient bot integration - #276

Closed
amp-rh wants to merge 2 commits into
mainfrom
remove-dead-slack-escalation-code
Closed

Remove unused jira-escalation command and SlackClient bot integration#276
amp-rh wants to merge 2 commits into
mainfrom
remove-dead-slack-escalation-code

Conversation

@amp-rh

@amp-rh amp-rh commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes dead code that was never wired up to any CI job or Prow step:

  • src/commands/jira_escalation.py — CLI command
  • src/escalation/jira_escalation.py — escalation logic
  • src/objects/slack_base.py — SlackClient bot token integration
  • Associated tests

Why

The jira-escalation command and SlackClient (bot token based) existed in the codebase but were never referenced in the step registry or any Prow job config. SLACK_BOT_TOKEN was never injected anywhere in CI.

Slack notifications for the report command are handled via incoming webhook in #274, which requires no bot token or SDK.

Test plan

  • Unit tests pass (uv run pytest tests/unittests/)
  • firewatch --help no longer lists jira-escalation

@openshift-ci

openshift-ci Bot commented Apr 22, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Neither the jira-escalation CLI command nor the SlackClient bot token
integration were wired up to any CI job or Prow step. Removing the dead
code: jira_escalation command, escalation logic, SlackClient class, and
associated tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@amp-rh
amp-rh force-pushed the remove-dead-slack-escalation-code branch from add29ae to e33ba44 Compare July 6, 2026 13:23
@redhat-chai-bot

Copy link
Copy Markdown

Code Review Summary

Clean deletion-only PR — 0 additions, 1,003 deletions across 7 files. CI is green ✅

What looks good

  • Complete removal — source files, CLI command registration, tests, and the package __init__.py are all removed together. No orphaned code or dead tests left behind.
  • CLI entry point is cleancli.py changes are minimal and correct; only the import and add_command for jira_escalation are removed. The remaining commands (report, jira_config_gen) are untouched.
  • CI passes — unit-test suite still passes, confirming nothing outside the escalation module depended on the removed code.
  • No logic changes — pure deletion, so no risk of introducing regressions.

One item to address

  • ⚠️ slack-sdk is still listed as a dependency in pyproject.toml — since SlackClient in src/objects/slack_base.py appears to be the sole consumer of slack-sdk, verify that nothing else in the repo imports slack_sdk. If nothing does, remove "slack-sdk>=3.35.0" from the dependencies list to avoid shipping an unnecessary runtime dependency.

Minor observations (non-blocking)

  • Confirm that no CI jobs, Dockerfiles, or wrapper scripts invoke firewatch jira-escalation externally — since the CLI subcommand is being removed, any external callers would break at runtime.
  • The tests/unittests/functions/escalation/ and tests/unittests/objects/slack/ directories should be empty after the deletions — Git doesn't track empty directories so this should be fine, but worth a quick check.

Overall: Well-scoped cleanup PR. Once the slack-sdk dependency question is addressed, this looks good to merge. 👍

@amp-rh
amp-rh marked this pull request as ready for review July 18, 2026 17:53
@amp-rh amp-rh closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants