Refactor dry data tracking into a DryData class with centralized printing - #180
Open
jyejare wants to merge 1 commit into
Open
Refactor dry data tracking into a DryData class with centralized printing#180jyejare wants to merge 1 commit into
jyejare wants to merge 1 commit into
Conversation
jyejare
commented
Jul 23, 2026
Collaborator
- Replace the shared module-level dry_data dict with a DryData class, instantiated per provider run and passed through providerCleanup and every resource entity instead of being re-imported everywhere.
- Fix DryData.reset_resource() to clear all sub-lists (delete/stop/skip) so stale entries can't leak between regions/zones.
- Centralize the repeated dry-run print/append logic into utils.print_dry_data(), used by all providers (aws, azure, gce, vmware, podman).
- Fix resourcewise_data() to operate on plain dicts, matching how it's actually invoked, and propagate dry_data through entities/providers.py.
- Add tests/test_dry_data.py covering DryData behavior and verifying two regions/zones produce disjoint, non-repeating dry data with no resources missing from the aggregated output.
- Add Docs/DRY_DATA_REFACTOR.md documenting the refactor.
…ting - Replace the shared module-level dry_data dict with a DryData class, instantiated per provider run and passed through providerCleanup and every resource entity instead of being re-imported everywhere. - Fix DryData.reset_resource() to clear all sub-lists (delete/stop/skip) so stale entries can't leak between regions/zones. - Centralize the repeated dry-run print/append logic into utils.print_dry_data(), used by all providers (aws, azure, gce, vmware, podman). - Fix resourcewise_data() to operate on plain dicts, matching how it's actually invoked, and propagate dry_data through entities/providers.py. - Add tests/test_dry_data.py covering DryData behavior and verifying two regions/zones produce disjoint, non-repeating dry data with no resources missing from the aggregated output. - Add Docs/DRY_DATA_REFACTOR.md documenting the refactor. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.