Fix empty JSON output to return "[]" instead of "{}" - #560
Open
ampandey-hub wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the contribution! The CI is currently failing because the commit message is missing the conventional commit category/type (fix:, feat:, test:, etc.). Could you please amend the commit message to something like: fix: return empty JSON array for collector list Once updated, the commit-pipeline check should pass. |
Collaborator
|
/packit test |
Collaborator
|
/packit build |
Archana-PandeyM
self-requested a review
August 21, 2026 15:50
When no data collectors are configured, 'rhc collector list --format json'
and 'rhc collector timers --format json' output {} (empty JSON object).
Since collectors are a list, the correct empty value is [] (empty array).
Resolves: RHEL-216725
Signed-off-by: Aman Pandey <ampandey@redhat.com>
ampandey-hub
force-pushed
the
fix/empty-json-array-output
branch
from
August 22, 2026 08:26
468022f to
fa70149
Compare
Collaborator
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no data collectors are configured, 'rhc collector list --format json'
and 'rhc collector timers --format json' output {} (empty JSON object).
Since collectors are a list, the correct empty value is [] (empty array).
Fix:
Changed two locations that explicitly print
{}to print[]instead:cmd/rhc/collector_cmd.go—collectorListActioninternal/ui/collector.go—printMachineReadableHow I tested
Resolves: RHEL-216725