fix(connect): clear RHSM spinner before the success line

[Sanika10114]

The connect spinner was still on the line when the checkmark was printed.
Resolves: RHEL-244670

[pkoprda]

Hi, thanks for the PR! The fix itself looks correct — stopping the spinner before printing the success line resolves the malformed output.
However, the commit's author and Signed-off-by are set to Super User <root@localhost.localdomain>, which is not a real identity. Please amend the commit with your actual name and email (git commit --amend --author="Your Name <your@email>" --signoff) before this can be merged.

[Sanika10114]

Hello @pkoprda,

Thanks for the review.
Amended the commit to use my Red Hat identity (Sanika Parihar sparihar@redhat.com) and updated Signed-off-by.

[pkoprda]

/packit build

[pkoprda]

LGTM, thanks!

[pkoprda]

I found that the rhc connect with incorrect credentials is still broken. Can you also fix that?

# rhc connect --disable-feature analytics --disable-feature remote-management                                                                                                                
Notice: ignoring preferences set via 'rhc configure features'.                                                                                                                                                      
                                                                                                                                                                                                                    
Connecting fedora-44 to Red Hat. Enabled features: content.                                                                                                                         
This might take some time.                                                                                                                                                                                          
                                                                                                                                                                                                                    
Username: foo                                                                                                                                                                                             
Password:                                                                                                                                                                                                           
                                                                                                                                                                                                                    
 [/] Connecting to Red Hat Subscription Management... [𐄂] Cannot connect to Red Hat Subscription Management                                                                                                         
  [𐄂] Skipping generation of Red Hat repository file                                                                                                                                                                
  [●] Analytics ... Skipped                                                                                                                                                                                         
  [●] Remote Management ... Skipped                                                                                                                                                                                 
                                                                                                                                                                                                                    
Manage your connected systems: https://red.ht/connector                                                                                                                                                             
                                                                                                                                                                                                                    
The following errors were encountered during connect:                                                                                                                                                               
                                                                                                                                                                                                                    
STEP  ERROR  
rhsm  cannot connect to Red Hat Subscription Management: registering with RHSM: Invalid username or password. To create a login, please visit https://www.redhat.com/wapps/ugc/register.html

Please see /var/log/rhc/rhc.log for full details.

Also your commit needs to be GPG-signed, because I wasn't able to merge this MR even when I approved it. See the commits in the main branch: https://github.com/RedHatInsights/rhc/commits/main/, the newest commits have the label Verified, your commit doesn't have that. It is a requirement for all the commits under Red Hat Insights organization.
See the documentation on how to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits.

[Sanika10114]

Hello @pkoprda

Stopped the RHSM spinner on the failure path as well (verified with bad credentials). Also GPG-signed the commit.

Many Thanks
Sanika

[Archana-PandeyM]

/packit build