Skip to content

chore: update embedding run IDs and centralize them per model#17

Merged
vojtech-cifka merged 1 commit into
masterfrom
chore/update-embedding-run-ids
Jun 16, 2026
Merged

chore: update embedding run IDs and centralize them per model#17
vojtech-cifka merged 1 commit into
masterfrom
chore/update-embedding-run-ids

Conversation

@vojtech-cifka

Copy link
Copy Markdown
Collaborator

Summary

Repoint the embedding configs at the newly generated embedding runs from the master branch and remove the storage disparity between the two models.

Notes

  • tissue_embedding_run_id (95a02c93...) in predict_linear_virchow2_lbfgs_tissue_tiles.yaml left unchanged — separate tissue-tiles run, not train/test embeddings.
  • Also expands the README with repository structure, setup, and usage.

Repoint Virchow2 and ProvGigaPath embedding configs at the new embedding runs
and remove the storage disparity between them.

Previously the Virchow2 run ID lived in dataset.yaml while the ProvGigaPath ID
was a literal duplicated across three experiment configs. Replace both with a
single per-model map in dataset.yaml:

    mlflow_artifacts.embedding_run_ids:
      virchow2:     262d680f52374614baaf19f1e4d05940
      provgigapath: 5099ce57e886411dababfc1234a88b23

All embedding configs now interpolate from this map, so each run ID has one
source of truth. No consumer code changes: nothing in Python reads
mlflow_artifacts.embedding_run_id; resolution is pure Hydra interpolation.

Also expand the README with repository structure, setup, and usage sections.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vojtech-cifka vojtech-cifka requested review from a team and vejtek June 14, 2026 21:33
@vojtech-cifka vojtech-cifka self-assigned this Jun 14, 2026
@vojtech-cifka vojtech-cifka requested a review from ejdam87 June 14, 2026 21:33
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vojtech-cifka, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe52733a-85dc-4864-8bdf-34ecc8a3cddb

📥 Commits

Reviewing files that changed from the base of the PR and between ecb0347 and 4667a4d.

📒 Files selected for processing (7)
  • README.md
  • configs/data/dataset.yaml
  • configs/experiment/ml/final_linear_provgigapath_adamw.yaml
  • configs/experiment/ml/final_linear_provgigapath_lbfgs.yaml
  • configs/experiment/ml/train_linear_provgigapath_adamw_group_kfold.yaml
  • configs/ml/task/final_linear_classifier.yaml
  • configs/ml/task/kfold_linear_classifier.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-embedding-run-ids

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md with comprehensive documentation regarding the repository structure, setup instructions using uv, and usage guidelines. Additionally, it refactors the configuration files to support multiple embedding models by replacing the single embedding_run_id with a dictionary of embedding_run_ids (specifically for virchow2 and provgigapath) and updates the corresponding experiment and task configurations to reference these new keys. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@vojtech-cifka vojtech-cifka merged commit 0e6bf51 into master Jun 16, 2026
3 checks passed
@vojtech-cifka vojtech-cifka deleted the chore/update-embedding-run-ids branch June 16, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants