Add trainer based pokemon filtering - #10
Open
tpolito wants to merge 1 commit into
Open
Conversation
Author
|
I was told via the discord that the Radical Red project isn't interested in contributions until after the next version release, however I already wrote the code, and figured at least people could weigh in on if this was a feature worth following up on after that version release. Thoughts are welcome. |
|
I really welcome this addition. I started using the calculator the other day and immediately wanted this feature. I created a fork of this project to start implementing it, and I see you have already done so. Perfect! Let's see this added to the calculator please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to filter Pokémon sets by trainer name in the damage calculator. If "Only show imported sets" is checked that takes priority and will show over the trainer filter.
📸 Screenshots
Testing
My branch is deployed and testable here