fix(android): configure embedded views on New Architecture - #291
Conversation
The Fabric view manager implemented the generated interface without returning its codegen delegate. React Native logged a soft exception when creating each embedded view, and placeholder properties skipped generated dispatch. Instantiate and return the generated delegate so placeholderName is routed through codegen. Remove the redundant ReactProp annotation; the Paper path is unchanged. #agentic
🛣️ ROKT Data Platform Paved Roads Scan Complete✅ No paved-road issues detected Scanned files against 2 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About ROKT Data Platform Paved Roads AgentThis scan was performed by the ROKT Data Platform Paved Roads Agent, an automated paved-road standards review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
🔒 Security Scan Complete✅ No security issues detected Scanned files against 64 rules. · Reviewed commit: 📜 Scan history (1 scan)
ℹ️ About PR Security AgentThis scan was performed by PR Security Agent, an automated security review tool for pull requests. See the User Guide for details on severity levels, feedback reactions, and scan configuration. Reply |
Background
RoktEmbeddedViewManagerimplements the codegen-generated interface but did not return its generated delegate fromgetDelegate().ReactNoCrashSoftExceptionwhenever it createdRoktNativeWidget, andplaceholderNamewas not routed through codegen property dispatch.What Has Changed
RoktNativeWidgetManagerDelegatein the New Architecture view manager and returned it fromgetDelegate().@ReactPropannotation because the generated delegate now ownsplaceholderNamedispatch.Screenshots/Video
RoktNativeWidgetdelegate soft exception no longer appears in logcat.Checklist
Additional Notes
trunk check --ci, Widget lint, TypeScript build, Expo plugin build, package creation, and the Android New Architecture build all pass.