Skip to content

fix(spur-tests): remove unused imports and variables#158

Merged
shiv-tyagi merged 1 commit intoROCm:mainfrom
shiv-tyagi:fix/spur-tests-unused-imports
May 7, 2026
Merged

fix(spur-tests): remove unused imports and variables#158
shiv-tyagi merged 1 commit intoROCm:mainfrom
shiv-tyagi:fix/spur-tests-unused-imports

Conversation

@shiv-tyagi
Copy link
Copy Markdown
Member

Drop unused HashMap, Arc, JobId, and partition imports from the test harness and scheduler tests. Mark job binding as immutable in GPU test.

Drop unused HashMap, Arc, JobId, and partition imports from the test
harness and scheduler tests. Mark job binding as immutable in GPU test.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleans up the spur-tests crate by removing unused imports and making a GPU test job binding immutable, reducing warnings and keeping test code minimal.

Changes:

  • Removed unused HashMap, Arc, and JobId imports from the test harness.
  • Removed an unused partition::* import from scheduler tests.
  • Changed a GPU test’s job binding from mut to immutable.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/spur-tests/src/t39_gpu.rs Makes the test job binding immutable where it is not mutated.
crates/spur-tests/src/t07_sched.rs Drops an unused partition module import from scheduler tests.
crates/spur-tests/src/harness.rs Removes unused std/core imports from the test harness module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shiv-tyagi
Copy link
Copy Markdown
Member Author

Reviewed myself and with copilot. Looking good. Merging.

@shiv-tyagi shiv-tyagi merged commit 548d706 into ROCm:main May 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants