Conversation
Remove unused `complete_step` (WAL path handles it), `get_jobs_by_name_user` (inline closure in `pending_jobs` covers it), and unused scheduler imports. Fix leader-forwarding in server.rs: replace unconditional `?` with match so the original "not leader" status (with leader-hint metadata) is returned when the proxy connection fails, and log the inner error via warn.
There was a problem hiding this comment.
Pull request overview
This PR cleans up unused controller/cluster code paths and adjusts gRPC leader-forwarding so that, when a follower can’t proxy to the leader, callers still receive the original “not leader” Status (including any leader-hint metadata) rather than a proxy-connection error.
Changes:
- Updated several
SlurmControllerRPC handlers to forward to the leader via an explicitmatch, logging proxy failures and returning the original not-leader status. - Removed dead
ClusterManagerAPIs (complete_step,get_jobs_by_name_user) and eliminated now-unused scheduler imports. - Minor test cleanup to drop an unused import.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/spurctld/src/server.rs |
Adjusts leader-forwarding behavior to preserve the original not-leader Status when proxying fails, and logs the proxy error. |
crates/spurctld/src/scheduler_loop.rs |
Removes an unused JobState import in tests. |
crates/spurctld/src/cluster.rs |
Removes dead step/job-query helpers and unused scheduler imports; simplifies an unused local in cancel_job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused
complete_step(WAL path handles it),get_jobs_by_name_user(inline closure inpending_jobscovers it), and unused scheduler imports.Fix leader-forwarding in server.rs: replace unconditional
?with match so the original "not leader" status (with leader-hint metadata) is returned when the proxy connection fails, and log the inner error via warn.