Fix CI artifact download failures in sGPU/mGPU test jobs#602
Draft
VeeraRajasekhar wants to merge 5 commits into
Draft
Fix CI artifact download failures in sGPU/mGPU test jobs#602VeeraRajasekhar wants to merge 5 commits into
VeeraRajasekhar wants to merge 5 commits into
Conversation
Copilot
AI
changed the title
upgrade ci to TheRock
Fix CI artifact download failures in sGPU/mGPU test jobs
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes intermittent CI failures in
sGPU Tests (mi30x)andmGPU Torch (mi35x)jobs caused by partial artifact downloads on slow self-hosted runners.Root Cause
All four build outputs were combined into a single
te-rocm-wheelsartifact (~743 MB). GitHub Actionsupload-artifact@v4stores files alphabetically in a zip, so the archive order was:transformer_engine-*.whl(~1 MB)transformer_engine_rocm7-*.whl(~700 MB)transformer_engine_rocm_jax-*.tar.gz(~20 MB)transformer_engine_rocm_torch-*.tar.gz(~20 MB)On slower self-hosted runners, downloading the 743 MB archive took 5–9+ minutes. The
download-artifact@v4action reported success even when the download was truncated, because the whl files (items 1 and 2) were extracted first. The tar.gz sdist files (items 3 and 4), which appear after the 700 MB whl in the zip, were never extracted. This caused the "Install packages" step to fail silently with an emptyTE_FW_PKGvariable.Fix
Split the single artifact into two:
te-rocm-wheels—.whlfiles only (~700 MB)te-rocm-sdists—.tar.gzsdist files only (~40 MB)The sdists are now downloaded in a separate, independent step. Because the sdist artifact is small (~40 MB), it downloads quickly and completely on all runners regardless of network speed, preventing the partial-extraction failure.
Changes
.github/workflows/rocm-wheels-build.yml: Replaced the singleupload-artifactstep with two steps — one for.whlpackages (te-rocm-wheels) and one for.tar.gzsdists (te-rocm-sdists)..github/workflows/rocm-ci.yml: Added aDownload sdist packagesstep in bothsgpu_testsandmgpu_testsjobs to download the newte-rocm-sdistsartifact alongside the existing wheel download.