speed up nvte_multi_padding / nvte_multi_unpadding#592
Open
matthiasdiener wants to merge 9 commits into
Open
Conversation
aris134
reviewed
Jun 1, 2026
aris134
reviewed
Jun 1, 2026
aris134
reviewed
Jun 1, 2026
aris134
requested changes
Jun 1, 2026
alextmagro
reviewed
Jun 3, 2026
| // falls back to element-wise for partial/unaligned cases. | ||
| // Note: NT loads were also benchmarked but hurt performance. | ||
| template <uint32_t nvec, typename Type> | ||
| __device__ __forceinline__ void nt_store_to_elts(const Vec<Type, nvec>& v, |
Contributor
There was a problem hiding this comment.
What is the case where we hit non-aligned vectors? Isn't FP8/MXFP8 always padded to a multiple of 16 by default? Ideally we would template out the NT vs elementwise stores
|
|
||
| #ifdef __HIP_PLATFORM_AMD__ | ||
| // Process subtiles with vectorized loads/stores | ||
| #pragma unroll |
Contributor
There was a problem hiding this comment.
Did you try #pragma unroll 2 here? If we have the registers available that might help performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes https://github.com/ROCm/frameworks-internal/issues/16530
See https://github.com/ROCm/frameworks-internal/issues/16530#issuecomment-4502138388 for performance.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: