removing secondary reordering#314
Open
AtlantaPepsi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect device grouping in the PodAllToAll preset by removing an unintended second reordering step and basing group construction directly on the Utils::StrideGenerate() permutation.
Changes:
- Builds the
deviceslist in the same order as theStrideGenerateoutput (instead of reindexing into a separately permuted layout). - Ensures group membership corresponds to contiguous chunks of the strided device order (fixing wrong grouping results in
poda2a).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nileshnegi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Quick fix for missed grouping change
Technical Details
Grouping should be based directly on
StrideGenerateoutput, previous vestige of a second layer of reordering is inpoda2aand caused wrong grouping results.Test Plan
Example:
With 3 nodes, each with 4 devices, NUM_GROUPS=4, GROUP_STRIDE=4 should result in
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] => [0, 4, 8, 1, 5, 9, 2, 6, 10, 3, 7, 11] => [0, 4, 8], [1, 5, 9], [2, 6, 10], [3, 7, 11]
Test Result
Submission Checklist