Skip to content

Refactor/fp8 8wave fx gemm call #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderfeli merged 2 commits into from
Jul 6, 2026
+30 −39
Merged

Refactor/fp8 8wave fx gemm call #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67ff89
Refactor fp8 8wave MFMA calls through fx.gemm
Jul 5, 2026
613ea6b
Rename fp8 8wave priority flag
Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 2 additions & 32 deletions kernels/fp8_gemm_8wave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,36 +138,24 @@ def kernel_gemm(
a_g2s.load(a_next1, A1_gl_offset + (k + 1) * BLOCK_K)
rocdl.s_barrier()

rocdl.s_setprio(1)
c00_frag = mfma.call(a0_frag, b0_frag, c00_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

b1_frag = b_s2r.load(b_cur1, preshuffled=b_preshuffled)
b_g2s.load(b_cur0, B0_gl_offset + (k + 2) * B_K_STEP)
rocdl.s_barrier()

rocdl.s_setprio(1)
c01_frag = mfma.call(a0_frag, b1_frag, c01_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

a1_frag = a_s2r.load(a_cur1)
a_g2s.load(a_cur0, A0_gl_offset + (k + 2) * BLOCK_K)
rocdl.s_barrier()

rocdl.s_setprio(1)
c10_frag = mfma.call(a1_frag, b0_frag, c10_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

b_g2s.load(b_cur1, B1_gl_offset + (k + 2) * B_K_STEP)
wait_barrier(2 * N_LDS_STEPS_A + N_LDS_STEPS_B)

rocdl.s_setprio(1)
c11_frag = mfma.call(a1_frag, b1_frag, c11_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

# Swap cur and next
a_cur0, a_next0 = a_next0, a_cur0
Expand All @@ -181,37 +169,25 @@ def kernel_gemm(
a0_frag = a_s2r.load(a_cur0)
rocdl.s_barrier()

rocdl.s_setprio(1)
c00_frag = mfma.call(a0_frag, b0_frag, c00_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

b1_frag = b_s2r.load(b_cur1, preshuffled=b_preshuffled)
rocdl.s_barrier()

rocdl.s_setprio(1)
c01_frag = mfma.call(a0_frag, b1_frag, c01_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

a1_frag = a_s2r.load(a_cur1)
# Main loop prefetches a_next1 one step behind; issue the final
# K_ITERS - 1 tile here, otherwise c10 / c11 read stale A1 data.
a_g2s.load(a_next1, A1_gl_offset + (K_ITERS - 1) * BLOCK_K)
rocdl.s_barrier()

rocdl.s_setprio(1)
c10_frag = mfma.call(a1_frag, b0_frag, c10_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

b0_frag = b_s2r.load(b_next0, preshuffled=b_preshuffled)
rocdl.s_barrier()

rocdl.s_setprio(1)
c11_frag = mfma.call(a1_frag, b1_frag, c11_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()
# Swap cur and next
a_cur0, a_next0 = a_next0, a_cur0
a_cur1, a_next1 = a_next1, a_cur1
Expand All @@ -223,25 +199,19 @@ def kernel_gemm(
a0_frag = a_s2r.load(a_cur0)
wait_barrier(0)

rocdl.s_setprio(1)
c00_frag = mfma.call(a0_frag, b0_frag, c00_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

b1_frag = b_s2r.load(b_cur1, preshuffled=b_preshuffled)
rocdl.s_barrier()

rocdl.s_setprio(1)
c01_frag = mfma.call(a0_frag, b1_frag, c01_frag)
rocdl.s_setprio(0)
rocdl.s_barrier()

a1_frag = a_s2r.load(a_cur1)
rocdl.s_barrier()

rocdl.s_setprio(1)
c10_frag = mfma.call(a1_frag, b0_frag, c10_frag)
c11_frag = mfma.call(a1_frag, b1_frag, c11_frag)
c10_frag = mfma.call(a1_frag, b0_frag, c10_frag, set_prio=False)
c11_frag = mfma.call(a1_frag, b1_frag, c11_frag, set_prio=False)
rocdl.s_setprio(0)
rocdl.s_barrier()

Expand Down
35 changes: 28 additions & 7 deletions kernels/fp8_gemm_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
# Copyright (c) 2025 FlyDSL Project Contributors

import flydsl.expr as fx
from flydsl._mlir.dialects import fly as fly_dialect
from flydsl._mlir.dialects import llvm as _llvm
from flydsl._mlir.dialects.fly_rocdl import TargetAddressSpace
from flydsl.expr import arith, const_expr, range_constexpr
from flydsl.expr import arith, const_expr, range_constexpr, rocdl
from flydsl.expr.typing import Vector as Vec


Expand Down Expand Up @@ -207,26 +206,48 @@ def wait_barrier(count):
class Mfma16x16x128:
def __init__(self, n_tiles_a, n_tiles_b):
self.atom = fx.make_mma_atom(fx.rocdl.cdna4.MFMA_Scale(16, 16, 128, fx.Float8E4M3FN))
self.accum_type = Vec.make_type(4, fx.Float32)
self.zero_value = Vec.filled(4, 0.0, fx.Float32)
self.n_tiles_a = n_tiles_a
self.n_tiles_b = n_tiles_b

def idx(self, i, j):
return i * self.n_tiles_b + j

def _make_operand_frag(self, value):
frag = fx.make_rmem_tensor(8, fx.Int32)
frag.store(Vec(value))
return frag

def _make_accum_frag(self, value):
frag = fx.make_rmem_tensor(4, fx.Float32)
frag.store(Vec(value))
return frag

def _do_mma(self, a, b, c):
return fly_dialect.mma_atom_call_ssa([self.accum_type], self.atom, a, b, c)
a_frag = self._make_operand_frag(a)
b_frag = self._make_operand_frag(b)
c_frag = self._make_accum_frag(c)
fx.gemm(self.atom, c_frag, a_frag, b_frag, c_frag)
return c_frag.load().ir_value()

def call(self, a, b, c):
def call(self, a, b, c, *, set_prio=True):
assert len(a) == self.n_tiles_a
assert len(b) == self.n_tiles_b
assert len(c) == self.n_tiles_a * self.n_tiles_b

a_frags = [self._make_operand_frag(a[idx]) for idx in range_constexpr(self.n_tiles_a)]
b_frags = [self._make_operand_frag(b[idx]) for idx in range_constexpr(self.n_tiles_b)]
c_frags = [self._make_accum_frag(c[idx]) for idx in range_constexpr(self.n_tiles_a * self.n_tiles_b)]
if const_expr(set_prio):
rocdl.s_setprio(1)
for i in range_constexpr(self.n_tiles_a):
for j in range_constexpr(self.n_tiles_b):
c[self.idx(i, j)] = self._do_mma(a[i], b[j], c[self.idx(i, j)])
return c
cf = c_frags[self.idx(i, j)]
fx.gemm(self.atom, cf, a_frags[i], b_frags[j], cf)
if const_expr(set_prio):
rocdl.s_setprio(0)
rocdl.s_barrier()
return [c_frags[idx].load().ir_value() for idx in range_constexpr(self.n_tiles_a * self.n_tiles_b)]

def call_one(self, a, b, c, i, j):
assert i < self.n_tiles_a and j < self.n_tiles_b
Expand Down
Loading