Skip to content

[rmsnorm] Add backward pass + forward store_rstd for training (PR 1/3, #769) #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhinpan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[rmsnorm] Add backward pass + forward store_rstd for training (PR 1/3, #769) #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d8cd30
[rmsnorm] Add backward pass + forward store_rstd for training (#769)
Jul 3, 2026
0c5f94c
[rmsnorm] Address review: honor eps, fix multi-GPU cache, dedup helper
Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion kernels/kernels_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,32 @@
from flydsl._mlir import ir
from flydsl._mlir.dialects import arith as _std_arith
from flydsl._mlir.dialects import builtin
from flydsl._mlir.dialects import fly as _fly
from flydsl._mlir.dialects import gpu as _gpu
from flydsl._mlir.dialects import llvm as _llvm
from flydsl._mlir.dialects import scf as _scf
from flydsl.expr import buffer_ops
from flydsl.expr import arith as _expr_arith
from flydsl.expr import buffer_ops, const_expr
from flydsl.expr.typing import T
from flydsl.runtime.device import get_rocm_arch, is_rdna_arch


def get_llvm_ptr(ptr, offset, dtype_bytes, ptr_type=None):
"""Build a global (address-space 1) ``!llvm.ptr`` at ``ptr + offset*dtype_bytes``.

Shared home for the LLVM-ptr arithmetic used by atomic/global accesses
(previously duplicated in hgemm_splitk.py and rmsnorm_kernel.py).
"""
if ptr_type is None:
ptr_type = ir.Type.parse("!llvm.ptr<1>")
base_ptr = _fly.extract_aligned_pointer_as_index(ptr_type, ptr)
base_ptr = _llvm.PtrToIntOp(T.i64, base_ptr).result
byte_offset = _expr_arith.index_cast(T.i64, fx.Index(offset) * fx.Index(dtype_bytes))
llvm_ptr = _llvm.AddOp(base_ptr, byte_offset, _llvm.IntegerOverflowFlags(0)).result
llvm_ptr = _llvm.IntToPtrOp(ptr_type, llvm_ptr).result
return llvm_ptr._value if const_expr(hasattr(llvm_ptr, "_value")) else llvm_ptr


@contextmanager
def _if_then(if_op, scf=None):
"""Context manager for SCF IfOp then-region across old/new Python APIs.
Expand Down
Loading